]> git.proxmox.com Git - qemu.git/commit
aio: Fix return value of aio_poll()
authorKevin Wolf <kwolf@redhat.com>
Wed, 16 Jan 2013 18:25:51 +0000 (19:25 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Thu, 17 Jan 2013 09:51:42 +0000 (10:51 +0100)
commit2ea9b58f0bc62445b7ace2381b4c4db7d5597e19
treeecf430017866c7275158d2d99f6312972e277a1e
parent6bf3ee07ff55aa795010a8e071826f38e9a26112
aio: Fix return value of aio_poll()

aio_poll() must return true if any work is still pending, even if it
didn't make progress, so that bdrv_drain_all() doesn't stop waiting too
early. The possibility of stopping early occasionally lead to a failed
assertion in bdrv_drain_all(), when some in-flight request was missed
and the function didn't really drain all requests.

In order to make that change, the return value as specified in the
function comment must change for blocking = false; fortunately, the
return value of blocking = false callers is only used in test cases, so
this change shouldn't cause any trouble.

Cc: qemu-stable@nongnu.org
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
aio-posix.c
aio-win32.c
include/block/aio.h
tests/test-aio.c