]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
audit: fix undefined behavior in bit shift for AUDIT_BIT
authorGaosheng Cui <cuigaosheng1@huawei.com>
Mon, 31 Oct 2022 02:10:21 +0000 (10:10 +0800)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Wed, 14 Dec 2022 13:00:24 +0000 (14:00 +0100)
commit2eabd11e9a1f116179befea2a3c738ec20102e5c
tree8c8f639e5c079d0097a21c693491c0e8fbe7fde1
parent14dfe4a1d3b871da2ff636978790f8c310f89d15
audit: fix undefined behavior in bit shift for AUDIT_BIT

[ Upstream commit 986d93f55bdeab1cac858d1e47b41fac10b2d7f6 ]

Shifting signed 32-bit value by 31 bits is undefined, so changing
significant bit to unsigned. The UBSAN warning calltrace like below:

UBSAN: shift-out-of-bounds in kernel/auditfilter.c:179:23
left shift of 1 by 31 places cannot be represented in type 'int'
Call Trace:
 <TASK>
 dump_stack_lvl+0x7d/0xa5
 dump_stack+0x15/0x1b
 ubsan_epilogue+0xe/0x4e
 __ubsan_handle_shift_out_of_bounds+0x1e7/0x20c
 audit_register_class+0x9d/0x137
 audit_classes_init+0x4d/0xb8
 do_one_initcall+0x76/0x430
 kernel_init_freeable+0x3b3/0x422
 kernel_init+0x24/0x1e0
 ret_from_fork+0x1f/0x30
 </TASK>

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
[PM: remove bad 'Fixes' tag as issue predates git, added in v2.6.6-rc1]
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit f5558fbda022b5898ff64ddd834709d2e433e8a1)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
include/uapi/linux/audit.h