]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
sched/uclamp: Fix a deadlock when enabling uclamp static key
authorQais Yousef <qais.yousef@arm.com>
Fri, 28 Aug 2020 12:56:10 +0000 (13:56 +0100)
committerKhalid Elmously <khalid.elmously@canonical.com>
Wed, 16 Sep 2020 09:15:01 +0000 (05:15 -0400)
commit2efab9fae971f38e86f8f2a45b9bf4fc86371036
tree7d660f1b64f0655748a9c82d625180b6a526be97
parent466c40a0353f2bda5ba45bb139ff6697353ea3ce
sched/uclamp: Fix a deadlock when enabling uclamp static key

BugLink: https://bugs.launchpad.net/bugs/1895174
[ Upstream commit e65855a52b479f98674998cb23b21ef5a8144b04 ]

The following splat was caught when setting uclamp value of a task:

  BUG: sleeping function called from invalid context at ./include/linux/percpu-rwsem.h:49

   cpus_read_lock+0x68/0x130
   static_key_enable+0x1c/0x38
   __sched_setscheduler+0x900/0xad8

Fix by ensuring we enable the key outside of the critical section in
__sched_setscheduler()

Fixes: 46609ce22703 ("sched/uclamp: Protect uclamp fast path code with static key")
Signed-off-by: Qais Yousef <qais.yousef@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20200716110347.19553-4-qais.yousef@arm.com
Signed-off-by: Qais Yousef <qais.yousef@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
kernel/sched/core.c