]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
binfmt_elf: Respect error return from `regset->active'
authorMaciej W. Rozycki <macro@mips.com>
Tue, 15 May 2018 22:32:45 +0000 (23:32 +0100)
committerPaul Burton <paul.burton@mips.com>
Thu, 19 Jul 2018 20:46:34 +0000 (13:46 -0700)
commit2f819db565e82e5f73cd42b39925098986693378
treefbfb103170ec8457f90cd80855e4550cdad7d5cd
parentcd87668d601f622e0ebcfea4f78d116d5f572f4d
binfmt_elf: Respect error return from `regset->active'

The regset API documented in <linux/regset.h> defines -ENODEV as the
result of the `->active' handler to be used where the feature requested
is not available on the hardware found.  However code handling core file
note generation in `fill_thread_core_info' interpretes any non-zero
result from the `->active' handler as the regset requested being active.
Consequently processing continues (and hopefully gracefully fails later
on) rather than being abandoned right away for the regset requested.

Fix the problem then by making the code proceed only if a positive
result is returned from the `->active' handler.

Signed-off-by: Maciej W. Rozycki <macro@mips.com>
Signed-off-by: Paul Burton <paul.burton@mips.com>
Fixes: 4206d3aa1978 ("elf core dump: notes user_regset")
Patchwork: https://patchwork.linux-mips.org/patch/19332/
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: James Hogan <jhogan@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
fs/binfmt_elf.c