]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
s390/qdio: don't touch the dsci in tiqdio_add_input_queues()
authorJulian Wiedmann <jwi@linux.ibm.com>
Tue, 18 Jun 2019 11:12:20 +0000 (13:12 +0200)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commit2fbbdfae97fa03991b3596d7efe97986437e80bf
tree1cd514be6f3b48e604017c6a3ea5a4b4bcfdc9df
parent17c2ee1abf27da1af19411b81684e09372ec3b20
s390/qdio: don't touch the dsci in tiqdio_add_input_queues()

BugLink: https://bugs.launchpad.net/bugs/1839036
commit ac6639cd3db607d386616487902b4cc1850a7be5 upstream.

Current code sets the dsci to 0x00000080. Which doesn't make any sense,
as the indicator area is located in the _left-most_ byte.

Worse: if the dsci is the _shared_ indicator, this potentially clears
the indication of activity for a _different_ device.
tiqdio_thinint_handler() will then have no reason to call that device's
IRQ handler, and the device ends up stalling.

Fixes: d0c9d4a89fff ("[S390] qdio: set correct bit in dsci")
Cc: <stable@vger.kernel.org>
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/s390/cio/qdio_thinint.c