]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
RDMA/iwpm: Fix uninitialized error code in iwpm_send_mapinfo()
authorGeert Uytterhoeven <geert@linux-m68k.org>
Wed, 29 Nov 2017 08:47:33 +0000 (09:47 +0100)
committerJason Gunthorpe <jgg@mellanox.com>
Wed, 13 Dec 2017 17:55:49 +0000 (10:55 -0700)
commit302d6424e4a293a5761997e6c9fc3dfb1e4c355f
treeb1cf81aaf5996e600ba6d343fe8f57cf56185468
parentac6dbf7fa4707c75a247b540cc0b5c881f3d0ba8
RDMA/iwpm: Fix uninitialized error code in iwpm_send_mapinfo()

With gcc-4.1.2:

    drivers/infiniband/core/iwpm_util.c: In function ‘iwpm_send_mapinfo’:
    drivers/infiniband/core/iwpm_util.c:647: warning: ‘ret’ may be used uninitialized in this function

Indeed, if nl_client is not found in any of the scanned has buckets, ret
will be used uninitialized.

Preinitialize ret to -EINVAL to fix this.

Fixes: 30dc5e63d6a5ad24 ("RDMA/core: Add support for iWARP Port Mapper user space service")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Tatyana Nikolova <tatyana.e.nikolova@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/core/iwpm_util.c