]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net_sched: fix a memory leak in atm_tc_init()
authorCong Wang <xiyou.wangcong@gmail.com>
Thu, 9 Jul 2020 03:13:59 +0000 (20:13 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 9 Jul 2020 19:31:28 +0000 (12:31 -0700)
commit306381aec7c2b5a658eebca008c8a1b666536cba
treed28155bb389847c2f3821f7a759895c7b65be460
parent13cf8aab7425a253070433b5a55b4209ceac8b19
net_sched: fix a memory leak in atm_tc_init()

When tcf_block_get() fails inside atm_tc_init(),
atm_tc_put() is called to release the qdisc p->link.q.
But the flow->ref prevents it to do so, as the flow->ref
is still zero.

Fix this by moving the p->link.ref initialization before
tcf_block_get().

Fixes: 6529eaba33f0 ("net: sched: introduce tcf block infractructure")
Reported-and-tested-by: syzbot+d411cff6ab29cc2c311b@syzkaller.appspotmail.com
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_atm.c