]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ip/ip6_gre: Fix non-point-to-point tunnel not generating IPv6 link local address
authorThomas Winter <Thomas.Winter@alliedtelesis.co.nz>
Tue, 31 Jan 2023 03:46:46 +0000 (16:46 +1300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 2 Feb 2023 03:52:22 +0000 (19:52 -0800)
commit30e2291f61f93f7132c060190f8360df52644ec1
treeaaa8ac689ff6ac4fc71cdbfad97c63d4b5bfe5b6
parent23ca0c2c93406bdb1150659e720bda1cec1fad04
ip/ip6_gre: Fix non-point-to-point tunnel not generating IPv6 link local address

We recently found that our non-point-to-point tunnels were not
generating any IPv6 link local address and instead generating an
IPv6 compat address, breaking IPv6 communication on the tunnel.

Previously, addrconf_gre_config always would call addrconf_addr_gen
and generate a EUI64 link local address for the tunnel.
Then commit e5dd729460ca changed the code path so that add_v4_addrs
is called but this only generates a compat IPv6 address for
non-point-to-point tunnels.

I assume the compat address is specifically for SIT tunnels so
have kept that only for SIT - GRE tunnels now always generate link
local addresses.

Fixes: e5dd729460ca ("ip/ip6_gre: use the same logic as SIT interfaces when computing v6LL address")
Signed-off-by: Thomas Winter <Thomas.Winter@alliedtelesis.co.nz>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv6/addrconf.c