]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
tracing/kprobes: Enforce kprobes teardown after testing
authorThomas Gleixner <tglx@linutronix.de>
Wed, 17 May 2017 08:19:49 +0000 (10:19 +0200)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Thu, 18 May 2017 01:50:27 +0000 (21:50 -0400)
commit30e7d894c1478c88d50ce94ddcdbd7f9763d9cdd
tree98e2513897c6bf963bb046542062007a7476c6ea
parentb9ef0326c05a008c3c576bd4d676208b50c344d5
tracing/kprobes: Enforce kprobes teardown after testing

Enabling the tracer selftest triggers occasionally the warning in
text_poke(), which warns when the to be modified page is not marked
reserved.

The reason is that the tracer selftest installs kprobes on functions marked
__init for testing. These probes are removed after the tests, but that
removal schedules the delayed kprobes_optimizer work, which will do the
actual text poke. If the work is executed after the init text is freed,
then the warning triggers. The bug can be reproduced reliably when the work
delay is increased.

Flush the optimizer work and wait for the optimizing/unoptimizing lists to
become empty before returning from the kprobes tracer selftest. That
ensures that all operations which were queued due to the probes removal
have completed.

Link: http://lkml.kernel.org/r/20170516094802.76a468bb@gandalf.local.home
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Cc: stable@vger.kernel.org
Fixes: 6274de498 ("kprobes: Support delayed unoptimizing")
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
include/linux/kprobes.h
kernel/kprobes.c
kernel/trace/trace_kprobe.c