]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
kconfig: qconf: fix signal connection to invalid slots
authorMasahiro Yamada <masahiroy@kernel.org>
Mon, 17 Aug 2020 16:36:29 +0000 (01:36 +0900)
committerKhalid Elmously <khalid.elmously@canonical.com>
Wed, 16 Sep 2020 09:13:26 +0000 (05:13 -0400)
commit30f14d676cb3ad2931be6a42c8ba00ad2d1f02ff
tree37dc79d88ba804c479e6fbb7ed9869ba6e57ae5e
parent81de1856ec366a2ac0d66d94ce79f689cd9507c2
kconfig: qconf: fix signal connection to invalid slots

BugLink: https://bugs.launchpad.net/bugs/1893115
[ Upstream commit d85de3399f97467baa2026fbbbe587850d01ba8a ]

If you right-click in the ConfigList window, you will see the following
messages in the console:

QObject::connect: No such slot QAction::setOn(bool) in scripts/kconfig/qconf.cc:888
QObject::connect:  (sender name:   'config')
QObject::connect: No such slot QAction::setOn(bool) in scripts/kconfig/qconf.cc:897
QObject::connect:  (sender name:   'config')
QObject::connect: No such slot QAction::setOn(bool) in scripts/kconfig/qconf.cc:906
QObject::connect:  (sender name:   'config')

Right, there is no such slot in QAction. I think this is a typo of
setChecked.

Due to this bug, when you toggled the menu "Option->Show Name/Range/Data"
the state of the context menu was not previously updated. Fix this.

Fixes: d5d973c3f8a9 ("Port xconfig to Qt5 - Put back some of the old implementation(part 2)")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
scripts/kconfig/qconf.cc