]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
pinctrl: at91-pio4: add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Wed, 23 May 2018 19:07:12 +0000 (21:07 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 1 Mar 2019 13:20:39 +0000 (14:20 +0100)
commit30f2350920aeef3a3b7c049cfbcb0ba98aa5b81b
treeb7d9f53cc8441ee6d61521a82b3b7cad6edb227a
parent371cb354fd9cba2ccc3477c8fd82e8f9a977e7d1
pinctrl: at91-pio4: add missing of_node_put

BugLink: http://bugs.launchpad.net/bugs/1815234
[ Upstream commit 21816364715f508c10da1e087e352bc1e326614f ]

The device node iterators perform an of_node_get on each iteration, so a
jump out of the loop requires an of_node_put.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
+  of_node_put(child);
?  break;
   ...
}
... when != child
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/pinctrl/pinctrl-at91-pio4.c