]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
target: Fix race with SCF_SEND_DELAYED_TAS handling
authorNicholas Bellinger <nab@linux-iscsi.org>
Fri, 5 Feb 2016 22:51:36 +0000 (14:51 -0800)
committerNicholas Bellinger <nab@linux-iscsi.org>
Sat, 6 Feb 2016 23:59:38 +0000 (15:59 -0800)
commit310d3d314be7f0a84011ebdc4bdccbcae9755a87
treea16767f7254b15213a1f4950765c88a60a347a1c
parent0f4a943168f31d29a1701908931acaba518b131a
target: Fix race with SCF_SEND_DELAYED_TAS handling

This patch fixes a race between setting of SCF_SEND_DELAYED_TAS
in transport_send_task_abort(), and check of the same bit in
transport_check_aborted_status().

It adds a __transport_check_aborted_status() version that is
used by target_execute_cmd() when se_cmd->t_state_lock is
held, and a transport_check_aborted_status() wrapper for
all other existing callers.

Also, it handles the case where the check happens before
transport_send_task_abort() gets called.  For this, go
ahead and set SCF_SEND_DELAYED_TAS early when necessary,
and have transport_send_task_abort() send the abort.

Cc: Quinn Tran <quinn.tran@qlogic.com>
Cc: Himanshu Madhani <himanshu.madhani@qlogic.com>
Cc: Sagi Grimberg <sagig@mellanox.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Andy Grover <agrover@redhat.com>
Cc: Mike Christie <mchristi@redhat.com>
Cc: stable@vger.kernel.org # 3.10+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_transport.c