]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
Revert "serial: max310x: pass return value of spi_register_driver"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 May 2021 11:56:37 +0000 (13:56 +0200)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Thu, 15 Jul 2021 17:22:42 +0000 (19:22 +0200)
commit313419154d44843636c3e9bf5c6fb84ccdd34310
tree93103e2586e8cab7c3b17b575f11aea17a35a9f3
parent43ed7e5666cae35e5cd584939f3e2a6dcd8653c8
Revert "serial: max310x: pass return value of spi_register_driver"

BugLink: https://bugs.launchpad.net/bugs/1931896
[ Upstream commit b0a85abbe92e1a6f3e8580a4590fa7245de7090b ]

This reverts commit 51f689cc11333944c7a457f25ec75fcb41e99410.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

This change did not properly unwind from the error condition, so it was
not correct.

Cc: Kangjie Lu <kjlu@umn.edu>
Acked-by: Jiri Slaby <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20210503115736.2104747-11-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
drivers/tty/serial/max310x.c