]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
f2fs: wait on atomic writes to count F2FS_CP_WB_DATA
authorJaegeuk Kim <jaegeuk@kernel.org>
Fri, 28 Dec 2018 19:00:38 +0000 (11:00 -0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Tue, 8 Jan 2019 17:34:27 +0000 (09:34 -0800)
commit31867b23d7d1ee3535136c6a410a6cf56f666bfc
tree0e6b0c05ad5238939bf52b8d424be76a7462f6b0
parent3bd6e94bec122a951d462c239b47954cf5f36e33
f2fs: wait on atomic writes to count F2FS_CP_WB_DATA

Otherwise, we can get wrong counts incurring checkpoint hang.

IO_W (CP:  -24, Data:   24, Flush: (   0    0    1), Discard: (   0    0))

Thread A                        Thread B
- f2fs_write_data_pages
 -  __write_data_page
  - f2fs_submit_page_write
   - inc_page_count(F2FS_WB_DATA)
     type is F2FS_WB_DATA due to file is non-atomic one
- f2fs_ioc_start_atomic_write
 - set_inode_flag(FI_ATOMIC_FILE)
                                - f2fs_write_end_io
                                 - dec_page_count(F2FS_WB_CP_DATA)
                                   type is F2FS_WB_DATA due to file becomes
                                   atomic one

Cc: <stable@vger.kernel.org>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/file.c