]> git.proxmox.com Git - qemu.git/commit
scsi hotplug: Set DriveInfo member bus correctly
authorMarkus Armbruster <armbru@redhat.com>
Fri, 28 Jan 2011 10:21:36 +0000 (11:21 +0100)
committerKevin Wolf <kwolf@redhat.com>
Mon, 31 Jan 2011 09:03:00 +0000 (10:03 +0100)
commit31e1ea3ee7d05ab1aa134fe07a8f33b42417641f
tree1ed1137e0df6b3bb62e7e5894f04530d5aefd2fb
parent1b40bbd13a2d37dcd88763b84d01ec68bc96ff14
scsi hotplug: Set DriveInfo member bus correctly

drive_init() picks the first free bus and unit number, unless the user
specifies them.

This isn't a good fit for the drive_add monitor command, because there
we specify the controller by PCI address instead of using bus number
set by drive_init().

scsi_hot_add() takes care to replace the unit number set by
drive_init() by the real one, but it neglects to replace the bus
number.  Thus, bus/unit in DriveInfo may be bogus.  Affects
drive_get() and drive_get_max_bus().  I'm not aware of anything bad
happening because of that; looks like by the time we're hot-plugging,
the two functions aren't used anymore.  Fix it anyway.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
hw/pci-hotplug.c