]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
drm/i915: Use intel_panel_actually_set_backlight() to disable PWM backlight
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 24 Oct 2018 15:52:08 +0000 (18:52 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 31 Oct 2018 21:44:55 +0000 (23:44 +0200)
commit328f75bb0db718d21124d8804cf6bd353aa7b80d
treecd295be4551119361177d0fbfcfdb3a63b79239a
parent6e97272a9aaa5d4ec639c19d7f63a5d9b317dffb
drm/i915: Use intel_panel_actually_set_backlight() to disable PWM backlight

Use intel_panel_actually_set_backlight() instead of a direct
call to pwm_config() in pwm_disable_backlight().

The main benefit is consistent debug logging when we turn off the
backlight. Currently we see nothing in dmesg which made me wonder
whether the backlight was even getting turned off properly.

The second benefit is consistency; This is what we do for all
the other backlight implementations.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181024155208.18987-1-ville.syrjala@linux.intel.com
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/intel_panel.c