]> git.proxmox.com Git - mirror_zfs-debian.git/commit
Illumos #2671: zpool import should not fail if vdev ashift has increased
authorGeorge Wilson <gwilson@delphix.com>
Thu, 3 May 2012 12:49:19 +0000 (05:49 -0700)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Thu, 15 Nov 2012 19:05:59 +0000 (11:05 -0800)
commit32a9872bbae90a7cd9793c371f558701ec268976
tree03ac598a158bd8559e4eaac5223252c84a274cc3
parent3997bc74351d608e1a09f8ba8d58fb1c12fff331
Illumos #2671: zpool import should not fail if vdev ashift has increased

Reviewed by: Adam Leventhal <ahl@delphix.com>
Reviewed by: Eric Schrock <eric.schrock@delphix.com>
Reviewed by: Richard Elling <richard.elling@richardelling.com>
Reviewed by: Gordon Ross <gwr@nexenta.com>
Reviewed by: Garrett D'Amore <garrett@damore.org>
Approved by: Richard Lowe <richlowe@richlowe.net>

Refererces to Illumos issue:
      https://www.illumos.org/issues/2671

This patch has been slightly modified from the upstream Illumos
version.  In the upstream implementation a warning message is
logged to the console.  To prevent pointless console noise this
notification is now posted as a "ereport.fs.zfs.vdev.bad_ashift"
event.

The event indicates a non-optimial (but entirely safe) ashift
value was used to create the pool.  Depending on your workload
this may impact pool performance.  Unfortunately, the only way
to correct the issue is to recreate the pool with a new ashift.

NOTE: The unrelated fix to the comment in zpool_main.c appears
in the upstream commit and was preserved for consistnecy.

Ported-by: Cyril Plisko <cyril.plisko@mountall.com>
Reworked-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #955
cmd/zpool/zpool_main.c
include/sys/fm/fs/zfs.h
module/zfs/vdev.c
module/zfs/zfs_fm.c