]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
slightly reduce idiocy in drivers/staging/bcm/Misc.c
authorAl Viro <viro@zeniv.linux.org.uk>
Sun, 22 Jul 2012 17:02:01 +0000 (21:02 +0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Sun, 29 Jul 2012 17:24:20 +0000 (21:24 +0400)
commit32aecdd36528449cec34e6e63dcd5f0221ca7b43
tree2643f5ab53f1e1e934cef578e6f6b4cf1e0ca048
parente4fad8e5d220e3dfb1050eee752ee5058f29a232
slightly reduce idiocy in drivers/staging/bcm/Misc.c

a) vfs_llseek() does *not* access userland pointers of any kind
b) neither does filp_close(), for that matter
c) ... nor filp_open()
d) vfs_read() does, but we do have a wrapper for that (kernel_read()),
so there's no need to reinvent it.
e) passing current->files to filp_close() on something that never
had been in descriptor table is pointless.

ISAGN: voodoo dolls to be used on voodoo programmers...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
drivers/staging/bcm/Misc.c