]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
nfsd: return correct lockowner when there is a race on hash insert
authorJ. Bruce Fields <bfields@redhat.com>
Mon, 23 Mar 2015 15:02:30 +0000 (11:02 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Thu, 26 Mar 2015 01:06:16 +0000 (21:06 -0400)
commit340f0ba1c6c8412aa35fd6476044836b84361ea6
tree2c3fca4f7a7995a36545fdbaa311eeadfcdedaf9
parentc5952338bfc234e54deda45b7228f610a545e28a
nfsd: return correct lockowner when there is a race on hash insert

alloc_init_lock_stateowner can return an already freed entry if there is
a race to put openowners in the hashtable.

Noticed by inspection after Jeff Layton fixed the same bug for open
owners.  Depending on client behavior, this one may be trickier to
trigger in practice.

Fixes: c58c6610ec24 "nfsd: Protect adding/removing lock owners using client_lock"
Cc: <stable@vger.kernel.org>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>
Acked-by: Jeff Layton <jeff.layton@primarydata.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4state.c