]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
tcp: md5: do not use alloc_percpu()
authorEric Dumazet <edumazet@google.com>
Thu, 23 Oct 2014 19:58:58 +0000 (12:58 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 25 Oct 2014 20:10:04 +0000 (16:10 -0400)
commit349ce993ac706869d553a1816426d3a4bfda02b1
tree732254796f8ee7b580db164f2f9732a2e948093e
parent4cc40af08032a513e2e68fa6d7818b77179a86af
tcp: md5: do not use alloc_percpu()

percpu tcp_md5sig_pool contains memory blobs that ultimately
go through sg_set_buf().

-> sg_set_page(sg, virt_to_page(buf), buflen, offset_in_page(buf));

This requires that whole area is in a physically contiguous portion
of memory. And that @buf is not backed by vmalloc().

Given that alloc_percpu() can use vmalloc() areas, this does not
fit the requirements.

Replace alloc_percpu() by a static DEFINE_PER_CPU() as tcp_md5sig_pool
is small anyway, there is no gain to dynamically allocate it.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Fixes: 765cf9976e93 ("tcp: md5: remove one indirection level in tcp_md5sig_pool")
Reported-by: Crestez Dan Leonard <cdleonard@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp.c