]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
md/raid5: fix bug that could result in reads from a failed device.
authorNeilBrown <neilb@suse.de>
Tue, 25 Oct 2011 23:31:04 +0000 (10:31 +1100)
committerNeilBrown <neilb@suse.de>
Tue, 25 Oct 2011 23:31:04 +0000 (10:31 +1100)
commit355840e7a7e56bb2834fd3b0da64da5465f8aeaa
tree8ba816b2db3b96872f744c476c3d3d0d3f12fd23
parentbd860c53d4f9cad520d233e1ba690aaacfb39e9b
md/raid5: fix bug that could result in reads from a failed device.

This bug was introduced in 415e72d034c50520ddb7ff79e7d1792c1306f0c9
which was in 2.6.36.

There is a small window of time between when a device fails and when
it is removed from the array.  During this time we might still read
from it, but we won't write to it - so it is possible that we could
read stale data.

We didn't need the test of 'Faulty' before because the test on
In_sync is sufficient.  Since we started allowing reads from the early
part of non-In_sync devices we need a test on Faulty too.

This is suitable for any kernel from 2.6.36 onwards, though the patch
might need a bit of tweaking in 3.0 and earlier.

Cc: stable@kernel.org
Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/raid5.c