]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
net: dsa: b53: Keep CPU port as tagged in all VLANs
authorFlorian Fainelli <f.fainelli@gmail.com>
Fri, 5 Oct 2018 03:24:13 +0000 (20:24 -0700)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:54:08 +0000 (19:54 -0600)
commit366f7f7cf9ba04524f402945d9d039065e4f7aec
treebf588f20a101c6f07b1c1c92cb4e58cd0618ede7
parent157f3ad97c7aac5945dd45b8208faac7a3cbd2e1
net: dsa: b53: Keep CPU port as tagged in all VLANs

BugLink: https://bugs.launchpad.net/bugs/1836426
[ Upstream commit ca8931948344c485569b04821d1f6bcebccd376b ]

Commit c499696e7901 ("net: dsa: b53: Stop using dev->cpu_port
incorrectly") was a bit too trigger happy in removing the CPU port from
the VLAN membership because we rely on DSA to program the CPU port VLAN,
which it does, except it does not bother itself with tagged/untagged and
just usese untagged.

Having the CPU port "follow" the user ports tagged/untagged is not great
and does not allow for properly differentiating, so keep the CPU port
tagged in all VLANs.

Reported-by: Gerhard Wiesinger <lists@wiesinger.com>
Fixes: c499696e7901 ("net: dsa: b53: Stop using dev->cpu_port incorrectly")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/net/dsa/b53/b53_common.c