]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
ALSA: vmalloc buffers should use normal mmap
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>
Fri, 25 Mar 2011 06:51:54 +0000 (17:51 +1100)
committerTakashi Iwai <tiwai@suse.de>
Fri, 25 Mar 2011 10:13:12 +0000 (11:13 +0100)
commit3674f19dabd15f9541079a588149a370d888f4e6
tree4a963fa23c738536cc935000d07f2ebebcc8e00f
parent20b67dddcc5f29d3d0c900225d85e0ac655bc69d
ALSA: vmalloc buffers should use normal mmap

It's a big no-no to use pgprot_noncached() when mmap'ing such buffers
into userspace since they are mapped cachable in kernel space.

This can cause all sort of interesting things ranging from to garbled
sound to lockups on various architectures. I've observed that usb-audio
is broken on powerpc 4xx for example because of that.

Also remove the now unused snd_pcm_lib_mmap_noncached(). It's
an arch business to know when to use uncached mappings, there's
already hacks for MIPS inside snd_pcm_default_mmap() and other
archs are supposed to use dma_mmap_coherent().

(See my separate patch that adds dma_mmap_coherent() to powerpc)

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: <stable@kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
include/sound/pcm.h
sound/core/pcm_native.c