]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
irqchip/ti-sci-inta: Fix processing of masked irqs
authorGrygorii Strashko <grygorii.strashko@ti.com>
Wed, 8 Apr 2020 19:15:32 +0000 (22:15 +0300)
committerMarc Zyngier <maz@kernel.org>
Fri, 17 Apr 2020 07:59:28 +0000 (08:59 +0100)
commit3688b0db5c331f4ec3fa5eb9f670a4b04f530700
tree28d505d97c3bf3645b5a5791562a728911141d95
parentedfc23f6f9fdbd7825d50ac1f380243cde19b679
irqchip/ti-sci-inta: Fix processing of masked irqs

The ti_sci_inta_irq_handler() does not take into account INTA IRQs state
(masked/unmasked) as it uses INTA_STATUS_CLEAR_j register to get INTA IRQs
status, which provides raw status value.
This causes hard IRQ handlers to be called or threaded handlers to be
scheduled many times even if corresponding INTA IRQ is masked.
Above, first of all, affects the LEVEL interrupts processing and causes
unexpected behavior up the system stack or crash.

Fix it by using the Interrupt Masked Status INTA_STATUSM_j register which
provides masked INTA IRQs status.

Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver")
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Link: https://lore.kernel.org/r/20200408191532.31252-1-grygorii.strashko@ti.com
Cc: stable@vger.kernel.org
drivers/irqchip/irq-ti-sci-inta.c