]> git.proxmox.com Git - mirror_qemu.git/commit
block: Improve empty format-specific info dump
authorHanna Reitz <hreitz@redhat.com>
Mon, 20 Jun 2022 16:26:53 +0000 (18:26 +0200)
committerKevin Wolf <kwolf@redhat.com>
Wed, 1 Feb 2023 15:52:32 +0000 (16:52 +0100)
commit3716470b24f0f63090d59bcf28ad8fe6fb7835bd
treeb697430a0cb2706f27dd90b1a3ca2314d069803c
parentfcb9e05144db51966e1476790129dbff92a0bea4
block: Improve empty format-specific info dump

When a block driver supports obtaining format-specific information, but
that object only contains optional fields, it is possible that none of
them are present, so that dump_qobject() (called by
bdrv_image_info_specific_dump()) will not print anything.

The callers of bdrv_image_info_specific_dump() put a header above this
information ("Format specific information:\n"), which will look strange
when there is nothing below.  Modify bdrv_image_info_specific_dump() to
print this header instead of its callers, and only if there is indeed
something to be printed.

Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20220620162704.80987-2-hreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/qapi.c
include/block/qapi.h
qemu-io-cmds.c