]> git.proxmox.com Git - mirror_qemu.git/commit
Do not use %m in common code to print error messages
authorThomas Huth <thuth@redhat.com>
Fri, 18 Oct 2019 13:07:16 +0000 (15:07 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 22 Oct 2019 07:38:42 +0000 (09:38 +0200)
commit372a87a1d9f611cedeff2f679fe8da219f0b938f
tree705d9190f1cf286f6cd39c5fcaf894174d0cd3dc
parent30d6ff662d0411fcb98a577e58582690fc2c513c
Do not use %m in common code to print error messages

The %m format specifier is an extension from glibc - and when compiling
QEMU for NetBSD, the compiler correctly complains, e.g.:

/home/qemu/qemu-test.ELjfrQ/src/util/main-loop.c: In function 'sigfd_handler':
/home/qemu/qemu-test.ELjfrQ/src/util/main-loop.c:64:13: warning: %m is only
 allowed in syslog(3) like functions [-Wformat=]
             printf("read from sigfd returned %zd: %m\n", len);
             ^
Let's use g_strerror() here instead, which is an easy-to-use wrapper
around the thread-safe strerror_r() function.

While we're at it, also convert the "printf()" in main-loop.c into
the preferred "error_report()".

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20191018130716.25438-1-thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/misc/tmp421.c
util/main-loop.c
util/systemd.c