]> git.proxmox.com Git - mirror_ifupdown2.git/commit
Dont down an interface during ifreload just because the number of iface
authorRoopa Prabhu <roopa@cumulusnetworks.com>
Tue, 28 Apr 2015 04:18:14 +0000 (21:18 -0700)
committerSam Tannous <stannous@cumulusnetworks.com>
Wed, 3 Jun 2015 17:13:13 +0000 (13:13 -0400)
commit37592fc1889fb26fd97aaad0210ecf259da8c8f6
tree10454eb6f845dd7d0da81f34c900141f32af0d2c
parent5d664422b6a38010ba4ca27f96212d7830f56f6d
Dont down an interface during ifreload just because the number of iface
sections for that interface changed

Testing Done: tested ifreload with new iface section

problem stmt:
if the user adds a new section for an existing interface, I mark the
interface for down.
Basically the below:

               if len(newifaceobjlist) != len(lastifaceobjlist):
                    ifacedownlist.append(ifname)
                    continue

You rarely need to add a new section to the interfaces file. It is not
recommended even by the user guide.
sankaran was trying to add a new address. Which he could have added to
the same iface section.

But, looking at his trivial example, i am thinking of not marking an
interface for down if the user merely tried to add a new section to an
existing interface
(cherry picked from commit 65c62c02981cf6e2677b18c0aafcb3f2bd737b1b)
(cherry picked from commit 4453b1921fc3f8e959131cb5e1b9e79e0433cc08)
ifupdown2/ifupdown/ifupdownmain.py