]> git.proxmox.com Git - mirror_qemu.git/commit
hw/display/qxl: fix signed to unsigned comparison
authorAlon Levy <alevy@redhat.com>
Mon, 20 Jan 2014 16:57:12 +0000 (18:57 +0200)
committerGerd Hoffmann <kraxel@redhat.com>
Mon, 3 Feb 2014 10:05:15 +0000 (11:05 +0100)
commit3761abb167847e9d848588bf15c5d7476845f7e8
tree9b0264463c24eeb7ee8f5c5b8583cff5e7630448
parentf06b85218a41fd6f8e797a925f4ea75640b69c9e
hw/display/qxl: fix signed to unsigned comparison

Several small signedness / overflow corrections to qxl_create_guest_primary:
1. use 64 bit unsigned for size to avoid overflow possible from two 32
bit multiplicants.
2. correct sign for requested_height
3. add a more verbose error message when setting guest bug state (which
causes a complete guess blackout until reset, so it helps if it is
verbose).

Signed-off-by: Alon Levy <alevy@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
hw/display/qxl.c