]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
XArray: Fix xas_create_range() when multi-order entry present
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Mon, 28 Mar 2022 23:25:11 +0000 (19:25 -0400)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 27 Apr 2022 09:58:46 +0000 (11:58 +0200)
commit3773a06085878a85ffa46569d7ca769cb6a66adf
tree44fb630c8d4c084058c2686a097e97b573b8cc76
parente34dc35867e312d308dda151a130ba7bb709899d
XArray: Fix xas_create_range() when multi-order entry present

BugLink: https://bugs.launchpad.net/bugs/1969110
commit 3e3c658055c002900982513e289398a1aad4a488 upstream.

If there is already an entry present that is of order >= XA_CHUNK_SHIFT
when we call xas_create_range(), xas_create_range() will misinterpret
that entry as a node and dereference xa_node->parent, generally leading
to a crash that looks something like this:

general protection fault, probably for non-canonical address 0xdffffc0000000001:
0000 [#1] PREEMPT SMP KASAN
KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f]
CPU: 0 PID: 32 Comm: khugepaged Not tainted 5.17.0-rc8-syzkaller-00003-g56e337f2cf13 #0
RIP: 0010:xa_parent_locked include/linux/xarray.h:1207 [inline]
RIP: 0010:xas_create_range+0x2d9/0x6e0 lib/xarray.c:725

It's deterministically reproducable once you know what the problem is,
but producing it in a live kernel requires khugepaged to hit a race.
While the problem has been present since xas_create_range() was
introduced, I'm not aware of a way to hit it before the page cache was
converted to use multi-index entries.

Fixes: 6b24ca4a1a8d ("mm: Use multi-index entries in the page cache")
Reported-by: syzbot+0d2b0bf32ca5cfd09f2e@syzkaller.appspotmail.com
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 7521a97b1929042604bef6859f62fa8b4bbc077b)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
lib/test_xarray.c
lib/xarray.c