]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
media: ti-vpe: vpe: fix a v4l2-compliance failure about frame sequence number
authorBenoit Parrot <bparrot@ti.com>
Mon, 7 Oct 2019 15:10:00 +0000 (12:10 -0300)
committerSeth Forshee <seth.forshee@canonical.com>
Mon, 6 Jan 2020 14:15:56 +0000 (08:15 -0600)
commit37781b700b3c45c5464a65fd265ca197e9315102
tree240d77978dd8507009a2686ad880cf8bb3c39b38
parentc52844db6bb92dd0b7ea3a865c9c1e1657cbac68
media: ti-vpe: vpe: fix a v4l2-compliance failure about frame sequence number

BugLink: https://bugs.launchpad.net/bugs/1858428
[ Upstream commit 2444846c0dbfa4ead21b621e4300ec32c90fbf38 ]

v4l2-compliance fails with this message:

   fail: v4l2-test-buffers.cpp(294): \
(int)g_sequence() < seq.last_seq + 1
   fail: v4l2-test-buffers.cpp(740): \
buf.check(m2m_q, last_m2m_seq)
   fail: v4l2-test-buffers.cpp(974): \
captureBufs(node, q, m2m_q, frame_count, true)
   test MMAP: FAIL

The driver is failing to update the source frame sequence number in the
vb2 buffer object. Only the destination frame sequence was being
updated.

This is only a reporting issue if the user space app actually cares
about the frame sequence number. But it is fixed nonetheless.

Signed-off-by: Benoit Parrot <bparrot@ti.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
drivers/media/platform/ti-vpe/vpe.c