]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
verify_pefile: relax wrapper length check
authorRobbie Harwood <rharwood@redhat.com>
Mon, 20 Feb 2023 17:12:53 +0000 (12:12 -0500)
committerRoxana Nicolescu <roxana.nicolescu@canonical.com>
Wed, 17 May 2023 11:34:12 +0000 (13:34 +0200)
commit37fe5039db8c249c5ce464e48d327afabc22950c
treee77341e701e6251143b9d90805a1236df013d243
parent07b7c459da8c6738e74374c85e33799fa7eaa7a5
verify_pefile: relax wrapper length check

BugLink: https://bugs.launchpad.net/bugs/2017219
[ Upstream commit 4fc5c74dde69a7eda172514aaeb5a7df3600adb3 ]

The PE Format Specification (section "The Attribute Certificate Table
(Image Only)") states that `dwLength` is to be rounded up to 8-byte
alignment when used for traversal.  Therefore, the field is not required
to be an 8-byte multiple in the first place.

Accordingly, pesign has not performed this alignment since version
0.110.  This causes kexec failure on pesign'd binaries with "PEFILE:
Signature wrapper len wrong".  Update the comment and relax the check.

Signed-off-by: Robbie Harwood <rharwood@redhat.com>
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Jarkko Sakkinen <jarkko@kernel.org>
cc: Eric Biederman <ebiederm@xmission.com>
cc: Herbert Xu <herbert@gondor.apana.org.au>
cc: keyrings@vger.kernel.org
cc: linux-crypto@vger.kernel.org
cc: kexec@lists.infradead.org
Link: https://learn.microsoft.com/en-us/windows/win32/debug/pe-format#the-attribute-certificate-table-image-only
Link: https://github.com/rhboot/pesign
Link: https://lore.kernel.org/r/20230220171254.592347-2-rharwood@redhat.com/
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
crypto/asymmetric_keys/verify_pefile.c