]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
regulator: core: Resolve supplies before disabling unused regulators
authorJavier Martinez Canillas <javier@osg.samsung.com>
Thu, 16 Feb 2017 17:30:02 +0000 (14:30 -0300)
committerMark Brown <broonie@kernel.org>
Thu, 16 Feb 2017 18:15:01 +0000 (18:15 +0000)
commit3827b64dba27ebadb4faf51f2c91143e01ba1f6d
tree5940a9c045e077305778ec4e04f3d3bb2b46c5b8
parentd00b74613fb18dfd0a5aa99270ee2e72d5c808d7
regulator: core: Resolve supplies before disabling unused regulators

After commit 66d228a2bf03 ("regulator: core: Don't use regulators as
supplies until the parent is bound"), input supplies aren't resolved
if the input supplies parent device has not been bound. This prevent
regulators to hold an invalid reference if its supply parent device
driver probe is deferred.

But this causes issues on some boards where a PMIC's regulator use as
input supply a regulator from another PMIC whose driver is registered
after the driver for the former.

In this case the regulators for the first PMIC will fail to resolve
input supplies on regulators registration (since the other PMIC wasn't
probed yet). And when the core attempts to resolve again latter when
the other PMIC registers its own regulators, it will fail again since
the parent device isn't bound yet.

This will cause some parent supplies to never be resolved and wrongly
be disabled on boot due taking them as unused.

To solve this problem, also attempt to resolve the pending regulators
input supplies before disabling the unused regulators.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/core.c