]> git.proxmox.com Git - mirror_qemu.git/commit
projects / mirror_qemu.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 0aff637) | patch
char: Explain qmp_chardev_add()'s unusual error handling
authorMarkus Armbruster <armbru@redhat.com>
Mon, 19 May 2014 16:57:36 +0000 (18:57 +0200)
committerGerd Hoffmann <kraxel@redhat.com>
Wed, 21 May 2014 09:57:58 +0000 (11:57 +0200)
commit3894c78764e1e6d8ef82c7c097749d10cf8c3981
tree396605853d833088eb940e03b62d76ac3046f696tree
parent0aff637e920c0cdb74338c6f57005f2d7cab63d6commit | diff
char: Explain qmp_chardev_add()'s unusual error handling

Character backend open hasn't been fully converted to the Error API.
Some opens fail without setting an error.  qmp_chardev_add() needs to
detect when that happens, and set a generic error.  Explain that in a
comment, and inline error_is_set() for clarity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
qemu-char.c diff | blob | blame | history
QEMU mirror