]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
power: supply: ltc2941-battery-gauge: fix use-after-free
authorSven Van Asbroeck <thesven73@gmail.com>
Thu, 19 Sep 2019 15:11:37 +0000 (11:11 -0400)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 13 Mar 2020 05:19:20 +0000 (01:19 -0400)
commit38feb73cef748fb60b841b0c0999c5cbd88559d2
tree21a449576eac40fa5a1b4c84d336fd2d9bf2a582
parent27a22cbf2d3b6847de45d580594893cecd40670e
power: supply: ltc2941-battery-gauge: fix use-after-free

BugLink: https://bugs.launchpad.net/bugs/1867051
commit a60ec78d306c6548d4adbc7918b587a723c555cc upstream.

This driver's remove path calls cancel_delayed_work().
However, that function does not wait until the work function
finishes. This could mean that the work function is still
running after the driver's remove function has finished,
which would result in a use-after-free.

Fix by calling cancel_delayed_work_sync(), which ensures that
that the work is properly cancelled, no longer running, and
unable to re-schedule itself.

This issue was detected with the help of Coccinelle.

Cc: stable <stable@vger.kernel.org>
Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/power/supply/ltc2941-battery-gauge.c