]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
drm/gem: Document that handle_create must be the last step
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 22 Mar 2018 08:02:33 +0000 (09:02 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 26 Mar 2018 15:42:06 +0000 (17:42 +0200)
commit3903117609f40a0bc21b8c48533ac07a574c4cdc
tree2de4db493464148719b73231d6480b081de8b1ed
parent3f07f28b9712605d1adb589344ced72e8397dc8a
drm/gem: Document that handle_create must be the last step

It published the gem object to userspace, by that point other threads
can guess the id and start using it. And gem IDs are _very_ easy to
guess (it's just an idr).

Since gem objects is the only thing we allow drivers to create
themselves (all the kms/prime/syncobj stuff is handled by the core) no
other functions seem to be in need of this clarification.

Motivated by reviewing the xen-front kms driver.

Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180322080233.17266-1-daniel.vetter@ffwll.ch
drivers/gpu/drm/drm_gem.c