]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
i40e: fix crash when Rx descriptor count is changed
authorBjörn Töpel <bjorn.topel@intel.com>
Fri, 12 Jun 2020 11:47:31 +0000 (13:47 +0200)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Fri, 19 Jun 2020 05:37:25 +0000 (22:37 -0700)
commit3995ecbabc6f8019b3a55aeb551eeb9598b8b354
tree31cd38e14cc5b4b5262079f6d93ef0fc79ad91eb
parentb1d95cc2391ffac0c5b27256a4fb0d2cfb021a29
i40e: fix crash when Rx descriptor count is changed

When the AF_XDP buffer allocator was introduced, the Rx SW ring
"rx_bi" allocation was moved from i40e_setup_rx_descriptors()
function, and was instead done in the i40e_configure_rx_ring()
function.

This broke the ethtool set_ringparam() hook for changing the Rx
descriptor count, which was relying on i40e_setup_rx_descriptors() to
handle the allocation.

Fix this by adding an explicit i40e_alloc_rx_bi() call to
i40e_set_ringparam().

Fixes: be1222b585fd ("i40e: Separate kernel allocated rx_bi rings from AF_XDP rings")
Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40e/i40e_ethtool.c