]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
media: s5c73m3-core: fix logic on a timeout condition
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 19 Dec 2017 11:43:37 +0000 (06:43 -0500)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 7 Mar 2018 10:55:05 +0000 (05:55 -0500)
commit39ad07b7de82bff26118a69e680cda3d081392dc
tree4bbefdbe7e13e6008cc0f8092afedc652c5c6c16
parent8239bac18a760249c800eb032acc3f66cba8df04
media: s5c73m3-core: fix logic on a timeout condition

As warned by smatch:
drivers/media/i2c/s5c73m3/s5c73m3-core.c:268 s5c73m3_check_status() error: uninitialized symbol 'status'.

if s5c73m3_check_status() is called too late, time_is_after_jiffies(end)
will return 0, causing the while to abort before reading status.

The current code will do the wrong thing here, as it will still
check if status != value. The right fix here is to change
the logic to ensure that it will always read the status.

Suggested-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/i2c/s5c73m3/s5c73m3-core.c