]> git.proxmox.com Git - pve-manager.git/commit
projects / pve-manager.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: aacfcde) | patch
ui: ResourceGrid: correctly remove ResourceStore listener
authorDominik Csapak <d.csapak@proxmox.com>
Thu, 20 May 2021 14:59:16 +0000 (16:59 +0200)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Thu, 20 May 2021 19:00:38 +0000 (21:00 +0200)
commit39fe40d8a200b80292cae47b1e28cddb26d44ee7
tree926ace9482fdac26da2fb162998e69ef534251actree
parentaacfcde0e6592d21601d28bb3993213f2cdd351bcommit | diff
ui: ResourceGrid: correctly remove ResourceStore listener

while the function in '.on' and '.un' are identical, they are not the
*same* function, thus the '.un' does not really remove the listener,
and we have leftover references to the grid which means it will never
really garbage-collected

instead, use '.mon' on the grid, which automatically cleans up the
listeners

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
www/manager6/grid/ResourceGrid.js diff | blob | blame | history
The Proxmox VE Management API and Web UI