]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
tcp: fix SNMP TCP timeout under-estimation
authorYuchung Cheng <ycheng@google.com>
Thu, 29 Nov 2018 00:06:45 +0000 (16:06 -0800)
committerMarcelo Henrique Cerri <marcelo.cerri@canonical.com>
Fri, 17 Jan 2020 17:22:19 +0000 (14:22 -0300)
commit3a0274cf92ecef88afdfdde8a2d4940f2b66ceee
treec8d21edccff31e70844a309883a3c2346836d96b
parentcb7720b0a463db7b7b454b6c4daa3c42ba0c065e
tcp: fix SNMP TCP timeout under-estimation

BugLink: https://bugs.launchpad.net/bugs/1857158
[ Upstream commit e1561fe2dd69dc5dddd69bd73aa65355bdfb048b ]

Previously the SNMP TCPTIMEOUTS counter has inconsistent accounting:
1. It counts all SYN and SYN-ACK timeouts
2. It counts timeouts in other states except recurring timeouts and
   timeouts after fast recovery or disorder state.

Such selective accounting makes analysis difficult and complicated. For
example the monitoring system needs to collect many other SNMP counters
to infer the total amount of timeout events. This patch makes TCPTIMEOUTS
counter simply counts all the retransmit timeout (SYN or data or FIN).

Signed-off-by: Yuchung Cheng <ycheng@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
net/ipv4/tcp_timer.c