]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
xfs: prevent leaking uninitialized stack memory in FSGEOMETRY_V1
authorDan Rosenberg <drosenberg@vsecurity.com>
Mon, 14 Feb 2011 13:45:28 +0000 (13:45 +0000)
committerAlex Elder <aelder@sgi.com>
Tue, 22 Feb 2011 21:06:47 +0000 (15:06 -0600)
commit3a3675b7f23f83ca8c67c9c2b6edf707fd28d1ba
treeca218171c9493272b40a4bb9c9a2099ba1240a47
parentd8204a37baf5474d3154eb536c936369be2bd5c0
xfs: prevent leaking uninitialized stack memory in FSGEOMETRY_V1

The FSGEOMETRY_V1 ioctl (and its compat equivalent) calls out to
xfs_fs_geometry() with a version number of 3.  This code path does not
fill in the logsunit member of the passed xfs_fsop_geom_t, leading to
the leaking of four bytes of uninitialized stack data to potentially
unprivileged callers.

v2 switches to memset() to avoid future issues if structure members
change, on suggestion of Dave Chinner.

Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
Reviewed-by: Eugene Teo <eugeneteo@kernel.org>
Signed-off-by: Alex Elder <aelder@sgi.com>
fs/xfs/xfs_fsops.c