]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
scsi: target: tcmu: Fix a use after free in tcmu_check_expired_queue_cmd()
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 23 May 2020 10:11:29 +0000 (13:11 +0300)
committerKhalid Elmously <khalid.elmously@canonical.com>
Sat, 8 Aug 2020 05:53:12 +0000 (01:53 -0400)
commit3ad68ecda426ca01c6fb179e64a5a3f652bfc9c3
tree91f205f2f14d7d47ee20fd8a5314fd1ddad1a240
parenta54a94bb55373f5dbe792c1732e6dba87014aed5
scsi: target: tcmu: Fix a use after free in tcmu_check_expired_queue_cmd()

BugLink: https://bugs.launchpad.net/bugs/1885322
[ Upstream commit 9d7464b18892332e35ff37f0b024429a1a9835e6 ]

The pr_debug() dereferences "cmd" after we already freed it by calling
tcmu_free_cmd(cmd).  The debug printk needs to be done earlier.

Link: https://lore.kernel.org/r/20200523101129.GB98132@mwanda
Fixes: 61fb24822166 ("scsi: target: tcmu: Userspace must not complete queued commands")
Reviewed-by: Mike Christie <mchristi@redhat.com>
Reviewed-by: David Disseldorp <ddiss@suse.de>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
drivers/target/target_core_user.c