]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
[PATCH] Fix swsusp with PNP BIOS
authorOndrej Zary <linux@rainbow-software.org>
Sun, 30 Jul 2006 10:03:55 +0000 (03:03 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Mon, 31 Jul 2006 20:28:41 +0000 (13:28 -0700)
commit3ae192080cb4d007792d13522efa98ebe7f15475
tree98786f16ad5946c907b17b6c46be1076349a4a3c
parent5b6509aa8c2f292caea7c0602ec361f920951508
[PATCH] Fix swsusp with PNP BIOS

swsusp is unable to suspend my machine (DTK FortisPro TOP-5A notebook) with
kernel 2.6.17.5 because it's unable to suspend PNP device 00:16 (mouse).

The problem is in PNP BIOS.  pnp_bus_suspend() calls pnp_stop_dev() for the
device if the device can be disabled according to pnp_can_disable().  The
problem is that pnpbios_disable_resources() returns -EPERM if the device is
not dynamic (!pnpbios_is_dynamic()) but insert_device() happily sets
PNP_DISABLE capability/flag even if the device is not dynamic.  So we try
to disable non-dynamic devices which will fail.  This patch prevents
insert_device() from setting PNP_DISABLE if the device is not dynamic and
fixes suspend on my system.

Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/pnp/pnpbios/core.c