]> git.proxmox.com Git - mirror_qemu.git/commit
block/dirty-bitmaps: add block_dirty_bitmap_check function
authorJohn Snow <jsnow@redhat.com>
Tue, 12 Mar 2019 16:05:49 +0000 (12:05 -0400)
committerJohn Snow <jsnow@redhat.com>
Tue, 12 Mar 2019 16:05:49 +0000 (12:05 -0400)
commit3ae96d66840f72ef54902d012dbdf87ef4e9fe0c
treefe639f5128dee3bde4350aecf3f7f61e3b34c55f
parent0064cfefa4e90c11e394befb7abe47602f2f30d7
block/dirty-bitmaps: add block_dirty_bitmap_check function

Instead of checking against busy, inconsistent, or read only directly,
use a check function with permissions bits that let us streamline the
checks without reproducing them in many places.

Included in this patch are permissions changes that simply add the
inconsistent check to existing permissions call spots, without
addressing existing bugs.

In general, this means that busy+readonly checks become BDRV_BITMAP_DEFAULT,
which checks against all three conditions. busy-only checks become
BDRV_BITMAP_ALLOW_RO.

Notably, remove allows inconsistent bitmaps, so it doesn't follow the pattern.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-id: 20190301191545.8728-4-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
block/dirty-bitmap.c
blockdev.c
include/block/dirty-bitmap.h
migration/block-dirty-bitmap.c
nbd/server.c