]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
HID: usbhid: Fix the check for HID_RESET_PENDING in hid_io_error
authorDon Zickus <dzickus@redhat.com>
Mon, 10 Aug 2015 16:06:53 +0000 (12:06 -0400)
committerJiri Kosina <jkosina@suse.cz>
Tue, 18 Aug 2015 21:59:41 +0000 (23:59 +0200)
commit3af4e5a95184d6d3c1c6a065f163faa174a96a1d
tree62030bed4af454188e57c1cf888724546961207a
parenta1c173dac102d7d91e5cafdb8cb212300063eaa3
HID: usbhid: Fix the check for HID_RESET_PENDING in hid_io_error

It was reported that after 10-20 reboots, a usb keyboard plugged
into a docking station would not work unless it was replugged in.

Using usbmon, it turns out the interrupt URBs were streaming with
callback errors of -71 for some reason.  The hid-core.c::hid_io_error was
supposed to retry and then reset, but the reset wasn't really happening.

The check for HID_NO_BANDWIDTH was inverted.  Fix was simple.

Tested by reporter and locally by me by unplugging a keyboard halfway until I
could recreate a stream of errors but no disconnect.

Signed-off-by: Don Zickus <dzickus@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/usbhid/hid-core.c