]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
greybus: hd: remove connection-create/destroy callbacks
authorJohan Hovold <johan@hovoldconsulting.com>
Thu, 17 Sep 2015 11:17:27 +0000 (13:17 +0200)
committerGreg Kroah-Hartman <gregkh@google.com>
Thu, 17 Sep 2015 21:35:47 +0000 (14:35 -0700)
commit3afe952127e6379b32ba0d845231dbe952d6117b
tree5bb2b6c7cd84052e665fb0b33bb1fffae9f5d217
parentd7ea30a57145d13a6e74c90e4f7277cb8705bcc1
greybus: hd: remove connection-create/destroy callbacks

These host-driver callbacks were intended to allow host drivers to
prepare a cport, something which can now be handled by the cport
enable/disable callbacks instead.

The current create/destroy are somewhat confusingly named as they were
not supposed to create or destroy connections. They were however called
from the unrelated helper functions that do create and destroy SVC
connections.

Furthermore, no errors were returned should the create callback fail,
which should have caused the connection initialisation to fail.

Remove these unused callbacks for now, and let us use the cport
enable/disable callbacks that should be able handle all host cport
initialisation (possibly after also adding an interface to provide
information for endpoint-cport mapping).

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/connection.c
drivers/staging/greybus/greybus.h