]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
checkpatch: net and drivers/net: warn on missing blank line after variable declaration
authorJoe Perches <joe@perches.com>
Thu, 3 Apr 2014 21:49:28 +0000 (14:49 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 3 Apr 2014 23:21:15 +0000 (16:21 -0700)
commit3b617e3b80548096eda92ebd8382f76b139e011c
treee2613eb994f3ff9c89bdcf21a954c8fbcdd0bc0e
parentcc93319b5f2471ff2042ce62ea6da1f3bb3ce394
checkpatch: net and drivers/net: warn on missing blank line after variable declaration

Networking prefers this style, so warn when it's not used.

Networking uses:

    void foo(int bar)
    {
        int baz;

        code...
   }

not

    void foo(int bar)
    {
        int baz;
        code...
    }

There are a limited number of false positives when using macros to
declare variables like:

  WARNING: networking uses a blank line after declarations
  #330: FILE: net/ipv4/inet_hashtables.c:330:
  + int dif = sk->sk_bound_dev_if;
  + INET_ADDR_COOKIE(acookie, saddr, daddr)

Signed-off-by: Joe Perches <joe@perches.com>
Cc: David Miller <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
scripts/checkpatch.pl