]> git.proxmox.com Git - mirror_qemu.git/commit
virtio-balloon: Disassociate from the balloon handlers on unplug
authorAmit Shah <amit.shah@redhat.com>
Fri, 9 Sep 2011 09:00:40 +0000 (14:30 +0530)
committerAnthony Liguori <aliguori@us.ibm.com>
Fri, 9 Sep 2011 17:58:16 +0000 (12:58 -0500)
commit3b86b13ab07407fc8c6ac0efbd717fe51df1cad7
tree9c5ac2837f9bfd7e1e9ca539c33a77fe3d341665
parent8a7d552cb3684570491a5ecaa8b78818404ed2fb
virtio-balloon: Disassociate from the balloon handlers on unplug

Adding a 2nd balloon device after unplugging the first one doesn't work.
Also, the 'info balloon' command should indicate an error mentioning no
balloon device is registered after unplug.

Reproduction steps given by Shaolong Hu:

(qemu) info balloon
Device 'balloon' has not been activated by the guest
(qemu) device_add virtio-balloon-pci,id=balloon1
(qemu) info balloon
balloon: actual=4096
(qemu) balloon 2048
(qemu) info balloon
balloon: actual=2048
(qemu) device_del balloon1
(qemu) info balloon
balloon: actual=4096
(qemu) balloon 2048
(qemu) info balloon
balloon: actual=4096
(qemu) device_del balloon1
Device 'balloon1' not found
(qemu) device_add virtio-balloon-pci,id=balloon1
Another balloon device already registered
Device 'virtio-balloon-pci' could not be initialized
(qemu) device_add virtio-balloon-pci,id=balloon2
Another balloon device already registered
Device 'virtio-balloon-pci' could not be initialized

Reported-by: Shaolong Hu <shu@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
hw/virtio-balloon.c