]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
xenbus: req->err should be updated before req->state
authorDongli Zhang <dongli.zhang@oracle.com>
Tue, 3 Mar 2020 22:14:23 +0000 (14:14 -0800)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Tue, 7 Apr 2020 08:52:19 +0000 (10:52 +0200)
commit3be06d1a55ed2a9489c68f2942ee4e31ee5e55fa
tree93643fbf40a67c1f01331f010ac228722ee3aa79
parentd00fb2ef490df04d926b3361fa163aec8dc87bba
xenbus: req->err should be updated before req->state

BugLink: https://bugs.launchpad.net/bugs/1870604
[ Upstream commit 8130b9d5b5abf26f9927b487c15319a187775f34 ]

This patch adds the barrier to guarantee that req->err is always updated
before req->state.

Otherwise, read_reply() would not return ERR_PTR(req->err) but
req->body, when process_writes()->xb_write() is failed.

Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
Link: https://lore.kernel.org/r/20200303221423.21962-2-dongli.zhang@oracle.com
Reviewed-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/xen/xenbus/xenbus_comms.c