]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
NFSv4.1: Fix up replays of interrupted requests
authorTrond Myklebust <trond.myklebust@primarydata.com>
Thu, 19 Oct 2017 19:46:45 +0000 (15:46 -0400)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Fri, 17 Nov 2017 18:47:58 +0000 (13:47 -0500)
commit3be0f80b5fe9c16eca2d538f799b94ca8aa59433
treeb6fc406f57844f26d03d1a0fc9229468f171146e
parent6f0afc28257dfa769c210f8f8da0f21d77e7452f
NFSv4.1: Fix up replays of interrupted requests

If the previous request on a slot was interrupted before it was
processed by the server, then our slot sequence number may be out of whack,
and so we try the next operation using the old sequence number.

The problem with this, is that not all servers check to see that the
client is replaying the same operations as previously when they decide
to go to the replay cache, and so instead of the expected error of
NFS4ERR_SEQ_FALSE_RETRY, we get a replay of the old reply, which could
(if the operations match up) be mistaken by the client for a new reply.

To fix this, we attempt to send a COMPOUND containing only the SEQUENCE op
in order to resync our slot sequence number.

Cc: Olga Kornievskaia <olga.kornievskaia@gmail.com>
[olga.kornievskaia@gmail.com: fix an Oops]
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
fs/nfs/nfs4_fs.h
fs/nfs/nfs4proc.c