]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
drm/radeon: Override fpfn for all VRAM placements in radeon_evict_flags
authorMichel Dänzer <michel.daenzer@amd.com>
Fri, 24 Mar 2017 10:01:09 +0000 (19:01 +0900)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Thu, 27 Apr 2017 13:03:54 +0000 (10:03 -0300)
commit3bf9223e679b60386ce0d6b59ba280e2744edb78
treea5f96e2de744ade34e026081959e9910a5aefba3
parentf4676f8b8c7c3e35e4925cc088ceb8fe43fe033d
drm/radeon: Override fpfn for all VRAM placements in radeon_evict_flags

BugLink: http://bugs.launchpad.net/bugs/1681862
commit ce4b4f228e51219b0b79588caf73225b08b5b779 upstream.

We were accidentally only overriding the first VRAM placement. For BOs
with the RADEON_GEM_NO_CPU_ACCESS flag set,
radeon_ttm_placement_from_domain creates a second VRAM placment with
fpfn == 0. If VRAM is almost full, the first VRAM placement with
fpfn > 0 may not work, but the second one with fpfn == 0 always will
(the BO's current location trivially satisfies it). Because "moving"
the BO to its current location puts it back on the LRU list, this
results in an infinite loop.

Fixes: 2a85aedd117c ("drm/radeon: Try evicting from CPU accessible to
                      inaccessible VRAM first")
Reported-by: Zachary Michaels <zmichaels@oblong.com>
Reported-and-Tested-by: Julien Isorce <jisorce@oblong.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/gpu/drm/radeon/radeon_ttm.c